[PATCH] D74086: [SystemZ] Add a subtarget cache like some other targets already have.

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

> We need the "+soft-float" feature in UsesVectorABI(), so we have the front end add it, so we don't need to check "-use-soft-float"="true", like the other targets, right?

Yes, I think that's correct.



================
Comment at: llvm/test/CodeGen/SystemZ/function-attributes-01.ll:11
+; Test per function attributes and command line arguments that override them.
+
+attributes #1 = { "target-cpu"="z14" "target-features"="+vector" }
----------------
Would be good to have some tests with "target-features"="-soft-float" as well.


================
Comment at: llvm/test/CodeGen/SystemZ/function-attributes-01.ll:30
+; SOFT-FLOAT:  lg %r2, 0(%r2)
+; NO-SOFT-FL:  ld %f0, 0(%r2)
+; NO-VECTOR:   lg %r2, 0(%r2)
----------------
This seems strange, an explicit per-function +soft-float should override the general setting, right?


================
Comment at: llvm/test/CodeGen/SystemZ/function-attributes-01.ll:63
+; SOFT-FLOAT-NEXT: lgr %r2, %r0
+; NO-SOFT-FL:      vl %v24, 0(%r2), 4
+; NO-VECTOR:       lg %r0, 0(%r2)
----------------
Same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74086/new/

https://reviews.llvm.org/D74086