[PATCH] D74204: [DebugInfo] Reject line tables of version > 5

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ikudrin, probinson, JDevlieghere, dblaikie, MaskRay.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
jhenderson edited the summary of this revision.
jhenderson added a parent revision: D74202: [DebugInfo][test] Replace pre-canned binary test.
Herald added a subscriber: ormris.

If a debug line section with version of greater than 5 is encountered, prior to this change the parser would accept it and treat it as version 5. This might work to some extent, but then it might not at all, as it really depends on the format of the unspecified future version, which will be different (otherwise there would be no point in changing the version number). Any information we could provide has a good chance of being invalid, so we should just refuse to parse such tables.

Depends on D74202 <https://reviews.llvm.org/D74202>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74204

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74204.243112.patch
Type: text/x-patch
Size: 22188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200207/7ed1b7ec/attachment.bin>