[PATCH] D74202: [DebugInfo][test] Replace pre-canned binary test

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ikudrin, JDevlieghere, probinson, dblaikie, MaskRay.
Herald added a subscriber: aprantl.
Herald added a project: LLVM.

The DebugInfo/dwarfdump-invalid-line-table test used a pre-canned binary generated by a fuzzer to demonstrate a bug fix. Unfortunately, the binary is rigid and requires hand-editing if we change behaviour, such as rejecting certain properties within it (as I plan on doing in another change).

Rather than hand-edit the binary, I have replaced it with two tests. The first tests the high-level code path from the debug line parser that produces the same error as this test previously did, and the second is a set of unit test cases that comprehensively cover the FormValue::skipValue method, which in turn covers the area that the original bug fix touched.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74202

Files:
  llvm/test/DebugInfo/Inputs/invalid.linetable
  llvm/test/DebugInfo/dwarfdump-invalid-line-table.test
  llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/unittests/DebugInfo/DWARF/DWARFFormValueTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74202.243097.patch
Type: text/x-patch
Size: 15423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200207/ad19e0cb/attachment.bin>