[PATCH] D74115: [llvm-readobj][test] - Add a test for --elf-cg-profile option.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 01:15:59 PST 2020


jhenderson added a comment.

Aside: why is this switch prefixed with "elf"? I wouldn't think this section is ELF-specific in principle...



================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:1
+## This test checks how we handle --elf-cg-profile option.
+
----------------
handle the --elf-cg-profile...


================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:32
+    Entries:
+      - From:   1
+        To:     2
----------------
Maybe refer to the symbols by name for clarity/robustness?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74115/new/

https://reviews.llvm.org/D74115





More information about the llvm-commits mailing list