[PATCH] D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 15:20:35 PST 2020


aprantl added a comment.

> Thanks for looking at these patches. When they are all ready to land would it be better to land them independently or all together as one?

I would land them as individual commits, but you can roll them into one push. Doin separate pushes makes it easier to debug bot breakage though.



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:196
   /// Does this UserValue match the parameters?
-  bool match(const DILocalVariable *Var, const DIExpression *Expr,
+  bool match(const DILocalVariable *Var,
+             Optional<DIExpression::FragmentInfo> OtherFragment,
----------------
Orlando wrote:
> aprantl wrote:
> > matches?
> It hadn't crossed my mind to rename this. The UserLabel class has a `match()` method too. Would you like me to update both?
Sure, why not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74057/new/

https://reviews.llvm.org/D74057





More information about the llvm-commits mailing list