[PATCH] D74075: [mlir][VectorOps] Introduce a `vector.fma` op that works on n-D vectors and lowers to `llvm.intrin.fmuladd`

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:546
+/// ```
+///  vector.extractvalue {{.*}}[0] : vector<2x4xf32>
+///  vector.fma{{.*}} : vector<4xf32>
----------------
this is not a check pattern, so why not fill out the %a, %b, %c and ssa vars for readability?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74075/new/

https://reviews.llvm.org/D74075