[PATCH] D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass

[Ehud Katz via Phabricator via llvm-commits]

ekatz marked 2 inline comments as done.
ekatz added inline comments.


================
Comment at: llvm/test/Transforms/CodeExtractor/LoopExtractor_crash.ll:4
+
+; This test used to trigger an assert.
+
----------------
fhahn wrote:
> There are no arguments to promote and no functions to inline? Is -inline/-argpromotion needed? Also, please add some rudimentary checks. (you could use llvm/tools/update_test_checks.py)
inline and argpromotion shouldn't do anything but certainly not crash. This crash is observed in those cases.


================
Comment at: llvm/test/Transforms/CodeExtractor/LoopExtractor_infinite.ll:3
+
+; This test used to enter an infinite loop (until out of memory).
+
----------------
fhahn wrote:
> Is running -mergereturn required? Or is it enough to have the output of merge return as test case? Also it would be good to have some rudimentary checks.
opt must be run with mergereturn and loop-extract to observe the infinite loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69069/new/

https://reviews.llvm.org/D69069