[PATCH] D74053: [DebugInfo] Teach LDV how to handle identical variable fragments

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/live-debug-vars-intervals.mir:46
+  @global = external global i32, align 4
+  declare void @llvm.dbg.addr(metadata, metadata, metadata)
+  declare void @llvm.dbg.value(metadata, metadata, metadata)
----------------
Could be deleted.


================
Comment at: llvm/test/DebugInfo/X86/live-debug-vars-intervals.mir:48
+  declare void @llvm.dbg.value(metadata, metadata, metadata)
+  declare void @llvm.stackprotector(i8*, i8**)
+  declare void @escape(i32*)
----------------
Could be deleted.


================
Comment at: llvm/test/DebugInfo/X86/live-debug-vars-intervals.mir:104
+alignment:       16
+exposesReturnsTwice: false
+legalized:       false
----------------
I think you do not need most of the attributes (probably only `name` and `alignment` ).


================
Comment at: llvm/test/DebugInfo/X86/live-debug-vars-intervals.mir:167
+alignment:       16
+exposesReturnsTwice: false
+legalized:       false
----------------
Here as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74053/new/

https://reviews.llvm.org/D74053