[PATCH] D73999: [MC][ELF] Warn changed section type or flags

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 22:08:11 PST 2020


MaskRay planned changes to this revision.
MaskRay added a comment.

Postpone this patch. We need to wait for the resolution to "what fields are used to differentiate two sections"

Currently it is (section_name,group_name,unique_id).
Adding linked_to_sym seems reasonable (D74006 <https://reviews.llvm.org/D74006>; it is hjl's GNU as patch will do). hjl and I favor it.
One opinion (@bd1976llvm's) is that sh_entsize should also be taken into account.
If we eventually add sh_type/sh_flags to the differentiator, then this patch will not be needed.

There are some discussions on D74006 <https://reviews.llvm.org/D74006> and https://bugs.llvm.org/show_bug.cgi?id=44775


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73999/new/

https://reviews.llvm.org/D73999





More information about the llvm-commits mailing list