[PATCH] D74047: [llvm-readobj] - Allow a situation when a section name is unknown.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 17:32:36 PST 2020


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5755
+    StringRef Name = "<?>";
+    Expected<StringRef> SecNameOrErr =
+        Obj->getSectionName(&Sec, this->WarningHandler);
----------------
```lang=cpp
    if (Expected<StringRef> SecNameOrErr =
            Obj->getSectionName(&Sec, this->WarningHandler))
      Name = *SecNameOrErr;
    else
      this->reportUniqueWarning(SecNameOrErr.takeError());
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74047/new/

https://reviews.llvm.org/D74047





More information about the llvm-commits mailing list