[PATCH] D73152: [PHIElimination] Compile time optimization for huge functions.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveVariables.cpp:820
+
+  SparseBitVector<> &BV = (*LiveInSets)[SuccBB->getNumber()];
+  for (auto R = BV.begin(), E = BV.end(); R != E; R++) {
----------------
qcolombet wrote:
> Shouldn't you check that LiveInSets is not nullptr?
> Otherwise, use a reference in the API.
Changed the LiveInSets argument to LiveVariables::addNewBlock() to be a reference instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73152/new/

https://reviews.llvm.org/D73152