[llvm] cd9142e - DebugInfo: Generalize test/DebugInfo/X86/convert-linked.ll to run with different architectures

[David Blaikie via llvm-commits]

Sorry for the delay - working on it now

On Wed, Feb 5, 2020 at 2:19 PM Petr Hosek <phosek at chromium.org> wrote:

> We're seeing the same failure on our AArch64 bots:
> https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8889258727239787472/+/steps/clang/0/steps/test/0/stdout
>
> On Wed, Feb 5, 2020 at 6:46 AM John Brawn via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Also, despite these tests now using the host triple they only get run
>> when the
>> X86 target is built (because test/DebugInfo/X86/lit.local.cfg makes them
>> unsupported when it's not), so these failures aren't showing up in the
>> AArch64
>> buildbots (e.g.
>> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick)
>> because they don't build the X86 target.
>>
>> John
>>
>> > -----Original Message-----
>> > From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>> > Behalf Of John Brawn via llvm-commits
>> > Sent: 05 February 2020 14:28
>> > To: David Blaikie
>> > Cc: llvm-commits at lists.llvm.org
>> > Subject: RE: [llvm] cd9142e - DebugInfo: Generalize
>> > test/DebugInfo/X86/convert-linked.ll to run with different architectures
>> >
>> > This test, and convert-debugloc test from commit
>> > efcd3967a6bf6b66e04e40129104d0b65ba453d2,
>> > are now failing on AArch64:
>> >
>> > llvm/test/DebugInfo/X86/convert-linked.ll:5:15: error: CHECK-NEXT:
>> > expected string not found in input
>> > ; CHECK-NEXT: DW_ATE_signed_8
>> >               ^
>> > <stdin>:43:2: note: scanning from here
>> >  DW_AT_name ("signed char")
>> >  ^
>> > <stdin>:44:18: note: possible intended match here
>> >  DW_AT_encoding (DW_ATE_signed_char)
>> >                  ^
>> >
>> > I think this is due to AArch64 using GlobalISel at -O0: looking at the
>> > llc debug
>> > output, the location information in DBG_VALUE ends up being $noreg  for
>> > some reason
>> > so no DW_AT_location is emitted. Changing to -O1 makes the failure go
>> > away (though I
>> > don’t know if that's the right way to fix the test).
>> >
>> > John
>> >
>> > > -----Original Message-----
>> > > From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>> > > Behalf Of David Blaikie via llvm-commits
>> > > Sent: 05 February 2020 02:03
>> > > To: llvm-commits at lists.llvm.org
>> > > Subject: [llvm] cd9142e - DebugInfo: Generalize
>> > > test/DebugInfo/X86/convert-linked.ll to run with different
>> > architectures
>> > >
>> > >
>> > > Author: David Blaikie
>> > > Date: 2020-02-04T18:02:03-08:00
>> > > New Revision: cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1
>> > >
>> > > URL: https://github.com/llvm/llvm-
>> > > project/commit/cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1
>> > > DIFF: https://github.com/llvm/llvm-
>> > > project/commit/cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1.diff
>> > >
>> > > LOG: DebugInfo: Generalize test/DebugInfo/X86/convert-linked.ll to run
>> > > with different architectures
>> > >
>> > > Added:
>> > >
>> > >
>> > > Modified:
>> > >     llvm/test/DebugInfo/X86/convert-linked.ll
>> > >
>> > > Removed:
>> > >
>> > >
>> > >
>> > >
>> > ########################################################################
>> > > ########
>> > > diff  --git a/llvm/test/DebugInfo/X86/convert-linked.ll
>> > > b/llvm/test/DebugInfo/X86/convert-linked.ll
>> > > index 8d277d8649e1..1f27d3f74053 100644
>> > > --- a/llvm/test/DebugInfo/X86/convert-linked.ll
>> > > +++ b/llvm/test/DebugInfo/X86/convert-linked.ll
>> > > @@ -1,4 +1,4 @@
>> > > -; RUN: llc -filetype=obj -O0 < %s | llvm-dwarfdump - | FileCheck %s
>> > > +; RUN: %llc_dwarf -filetype=obj -O0 < %s | llvm-dwarfdump - |
>> > FileCheck
>> > > %s
>> > >
>> > >  ; CHECK: DW_TAG_compile_unit
>> > >  ; CHECK: [[CU0BT0:0x[0-9a-f]+]]: DW_TAG_base_type
>> > > @@ -16,11 +16,6 @@
>> > >  ; CHECK: DW_TAG_variable
>> > >  ; CHECK: DW_OP_convert ([[CU1BT0]]) "DW_ATE_signed_8", DW_OP_convert
>> > > ([[CU1BT1]]) "DW_ATE_signed_16"
>> > >
>> > > -; ModuleID = 'llvm-link'
>> > > -source_filename = "llvm-link"
>> > > -target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
>> > > -target triple = "x86_64-unknown-linux-gnu"
>> > > -
>> > >  define dso_local signext i8 @foo(i8 signext %x) !dbg !9 {
>> > >  entry:
>> > >    call void @llvm.dbg.value(metadata i8 %x, metadata !13, metadata
>> > > !DIExpression()), !dbg !14
>> > >
>> > >
>> > >
>> > > _______________________________________________
>> > > llvm-commits mailing list
>> > > llvm-commits at lists.llvm.org
>> > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200205/32573262/attachment.html>