[PATCH] D74061: [mlir] Update generic op ebnf to include region

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 13:21:48 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG2697e8bc1e63: [mlir] Update generic op ebnf to include region (authored by jpienaar).

Changed prior to commit:
  https://reviews.llvm.org/D74061?vs=242637&id=242736#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74061/new/

https://reviews.llvm.org/D74061

Files:
  mlir/docs/LangRef.md
  mlir/lib/Parser/Parser.cpp


Index: mlir/lib/Parser/Parser.cpp
===================================================================
--- mlir/lib/Parser/Parser.cpp
+++ mlir/lib/Parser/Parser.cpp
@@ -3573,8 +3573,9 @@
 ///  operation         ::= op-result-list?
 ///                        (generic-operation | custom-operation)
 ///                        trailing-location?
-///  generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?
-///                        `:` function-type
+///  generic-operation ::= string-literal `(` ssa-use-list? `)`
+///                        successor-list? (`(` region-list `)`)?
+///                        attribute-dict? `:` function-type
 ///  custom-operation  ::= bare-id custom-operation-format
 ///  op-result-list    ::= op-result (`,` op-result)* `=`
 ///  op-result         ::= ssa-id (`:` integer-literal)
Index: mlir/docs/LangRef.md
===================================================================
--- mlir/docs/LangRef.md
+++ mlir/docs/LangRef.md
@@ -241,8 +241,8 @@
 ```
 operation         ::= op-result-list? (generic-operation | custom-operation)
                       trailing-location?
-generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?
-                      `:` function-type
+generic-operation ::= string-literal `(` ssa-use-list? `)`  successor-list?
+                      (`(` region-list `)`)? attribute-dict? `:` function-type
 custom-operation  ::= bare-id custom-operation-format
 op-result-list    ::= op-result (`,` op-result)* `=`
 op-result         ::= ssa-id (`:` integer-literal)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74061.242736.patch
Type: text/x-patch
Size: 1567 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200205/f58239cf/attachment.bin>


More information about the llvm-commits mailing list