[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

Wed Feb 5 10:15:27 PST 2020

MaskRay added a comment.

Another thing is whether we should use sh_flags/sh_type to differentiate sections. In addition, whether we should use sh_entsize.
If yes, the implementation can be a bit clumsy. We may have to add many `Elf*_Shdr` fields to `ELFSectionKey`.
If no (GNU as behavior), we should add warnings. D73999 <https://reviews.llvm.org/D73999> will do that.

The section group name is part of the key in both MC and GNU as. By analogy, SHF_LINK_ORDER+sh_link should probably be part of the key. Field not specified by the `.section` directive (sh_addrline,sh_addr,sh_offset,sh_info) should definitely not be part of the key.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006