[PATCH] D74072: [scudo][standalone] Fix a race in the secondary release

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 10:05:36 PST 2020


cryptoad marked an inline comment as done.
cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:100
           Entries[0].MapSize = H->MapSize;
+          Entries[0].Data = H->Data;
           Entries[0].Time = Time;
----------------
And I forgot to say that the `Data` field was not copied.
In practice this didn't matter since only Fuchsia is using it and it doesn't support caching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74072/new/

https://reviews.llvm.org/D74072





More information about the llvm-commits mailing list