[PATCH] D74060: [KnownBits] Move AND, OR and XOR logic into KnownBits

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

I'm not sure about this since the logic isn't completely obvious. What about KnowBits::computeForAND/computeForOR/computeForXOR helpers instead?



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1129
 
-    // Output known-0 bits are only known if clear in both the LHS & RHS.
-    Known.Zero &= Known2.Zero;
----------------
You have no equivalent to these comments which helps people understands whats going on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74060/new/

https://reviews.llvm.org/D74060