[PATCH] D74032: [DAGCombine][ARM] Combine pattern for REV16

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 07:35:28 PST 2020


SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:5698
   EVT VT = N->getValueType(0);
   if (VT != MVT::i32)
     return SDValue();
----------------
>This looks like it only works for MVT::i32 cases, but there doesn't seem to be any VT check?

That is checked here, but I will add an assert to `MatchBSwapHWordOrAndAnd`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74032/new/

https://reviews.llvm.org/D74032





More information about the llvm-commits mailing list