[PATCH] D74034: [yaml2obj] - Change NameIndex to StName for Symbol.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, with the comment changes, but you might want to wait to give others a chance to comment before committing.



================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-name.yaml:26
+## Check we allow specifying both Name and StName at once.
+## In this case StName has a priority, but symbol Name is still added
+## to the string symbol table.
----------------
has a priority -> has priority
but symbol name -> but the symbol name


================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-name.yaml:27
+## In this case StName has a priority, but symbol Name is still added
+## to the string symbol table.
+
----------------
string symbol -> symbol string


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74034/new/

https://reviews.llvm.org/D74034