[PATCH] D74034: [yaml2obj] - Change NameIndex to StName for Symbol.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:112
   Optional<uint8_t> Other;
+
+  Optional<uint32_t> StName;
----------------
Any particular reason for this blank line?


================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-name.yaml:26-27
+## Check we allow specifying both Name and NameIndex at once.
+## In this case StName has a priority, but symbol Name is still added
+## to the string symbol table.
+
----------------
It might be interesting to have something that references the symbol by name too in this case (e.g. a relocation or group section).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74034/new/

https://reviews.llvm.org/D74034