[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 05:13:43 PST 2020


bd1976llvm added a comment.

I think that this patch removes the need for uniquing sections for symbols with associated symbols which are explicitly assigned to a section name e.g. via __attribute__((section name)).

I have updated the comment in https://reviews.llvm.org/D72194 to say that. It would be a nice follow up change to remove the UniqueID added to sections for symbols with COMDATs/associated symbols that are explicitly assigned a section name.



================
Comment at: llvm/include/llvm/MC/MCContext.h:199
+    // combined into one section.
     struct ELFSectionKey {
       std::string SectionName;
----------------
Here start using "linked_to" terminology instead of "associated". Should we stick to just one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006





More information about the llvm-commits mailing list