[PATCH] D73442: [CMake] Support symlinking runtimes under a different name

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

This could be useful for us!

>From my reading of the code, if you have e.g. `armv7-none-linux-androideabi16` in your `LLVM_RUNTIME_TARGETS`, you could set `LLVM_RUNTIME_TARGET_armv7-none-linux-androideabi16_SYMLINK` to `armv7-none-linux-andrdoieabi` and it would create a symlink from `armv7-none-linux-androideabi` to `armv7-none-linux-androideabi16`. That's the opposite of what I'm reading in the description (though I think the code makes sense as-is).



================
Comment at: llvm/runtimes/CMakeLists.txt:563
+      foreach(name ${LLVM_RUNTIME_TARGETS})
+        foreach(symlink ${LLVM_RUNTIME_TARGET_${name}_SYMLINK})
+          if(CMAKE_HOST_UNIX)
----------------
Maybe SYMLINKS instead of SYMLINK to reflect that there can be multiple?


================
Comment at: llvm/runtimes/CMakeLists.txt:584
+
+          add_custom_target(install-runtimes-${symlink}
+                            DEPENDS install-runtimes-${name}
----------------
Use add_llvm_install_targets?


================
Comment at: llvm/runtimes/CMakeLists.txt:590
+                            USES_TERMINAL)
+          add_dependencies(install-runtimes install-runtimes-${symlink})
+        endforeach()
----------------
Add dependencies for the *-stripped targets too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73442/new/

https://reviews.llvm.org/D73442