[PATCH] D73712: [SCEV] SCEVExpander::isHighCostExpansionHelper(): bailout if no TTI is present

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 19:26:15 PST 2020


mkazantsev added a comment.

I'm not sure about how we should interpret lack of TTI. Maybe we should interpret it like "if there is no model, we don't care about the high costs, and everything is low cost enough", or opposite (like in your patch). Neither of this looks NFC to me (given that we can pass null TTI). Maybe we should merge it *after* we make use of TTI inside the methods?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73712/new/

https://reviews.llvm.org/D73712





More information about the llvm-commits mailing list