[PATCH] D73983: [mlir][ODS] Add documentation for the declarative assembly format.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added a comment.

Nice!



================
Comment at: mlir/docs/OpDefinitions.md:596
+* `operands`
+  -  Represents the operands of an operation.
+
----------------
"all the operands" to be clear.


================
Comment at: mlir/docs/OpDefinitions.md:603
+  - Represents the type of the given input.
+  - `input` must be either an operand, result, the `operands` directive, or the
+    `results` directive.
----------------
Say a bit more about variadic operand/result?


================
Comment at: mlir/docs/OpDefinitions.md:616
+A variable is an entity that has been registered on the operation itself, i.e.
+arguments, results, etc.
+
----------------
A variable ... an argument, result, attribute, etc.


================
Comment at: mlir/docs/OpDefinitions.md:632
+1. Must not contain overlapping information; e.g. multiple instances of
+   'attr-dict', types, operands, etc.
+
----------------
Should we also mention what happens when we have both attr-dict and specific attributes using variables?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73983/new/

https://reviews.llvm.org/D73983