[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 16:14:05 PST 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:320
   unsigned UniqueID = Section->getUniqueID();
   ELFUniquingMap.erase(
+      ELFSectionKey{Section->getSectionName(), GroupName, "", UniqueID});
----------------
As a note: this is only used by renaming `.debug_*` to `.zdebug_*`, which don't do SHF_LINK_ORDER magic. So using an empty linked-to symbol name will be fine.

As I understand it, `.zdebug*` are deprecated. ELF toolchain moves to SHF_COMPRESSED, so we don't need to add more support to `.zdebug*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006





More information about the llvm-commits mailing list