[PATCH] D73030: GlobalISel: Assume G_INTRINSIC* are convergent

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 14:51:13 PST 2020


aemerson added a comment.

In D73030#1857864 <https://reviews.llvm.org/D73030#1857864>, @arsenm wrote:

> In D73030#1857808 <https://reviews.llvm.org/D73030#1857808>, @aemerson wrote:
>
> > If this change is made then CPU targets will need to create the new G_INTRINSIC_(DIVERGENT?) opcodes anyway, since not having sinkable intrinsics (like many vector ops, and some exotic scalar ones) won't be acceptable for optimization purposes. So I think we will need the two extra opcodes anyway. Unless we have a different mechanism to communicate this property, like an MI flag? Actually, the issue we had with "tail" attributes on the memcpy intrinsics might also benefit from finding a better solution to this properties issues.
>
>
> Eventually, but none of these are problems I want to work on solving right now. My goal is to avoid subtle problems in the future, so I still think we should just go with this for now.


Ok, we'll revisit this later then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73030/new/

https://reviews.llvm.org/D73030





More information about the llvm-commits mailing list