[PATCH] D73959: [mlir][spirv] Add dialect-specific attribute for target environment

Denis Khalikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 14:23:43 PST 2020


denis13 added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp:742
+          "limits must be a dictionary attribute containing two 32-bit integer "
+          "attribbutes 'max_compute_workgroup_invocations' and "
+          "'max_compute_workgroup_size'");
----------------
s/attribbutes/attributes/ ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73959/new/

https://reviews.llvm.org/D73959





More information about the llvm-commits mailing list