[PATCH] D73566: [AsmPrinter] Print FP constant in hexadecimal form instead

Tue Feb 4 13:46:44 PST 2020

RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

In D73566#1857569 <https://reviews.llvm.org/D73566#1857569>, @craig.topper wrote:

> In D73566#1857359 <https://reviews.llvm.org/D73566#1857359>, @RKSimon wrote:
>
> > @craig.topper Any comments?
>
>
> Seems reasonable to me. @RKSimon did you have a concern?

Sorry no, I was getting this confused with your old D37184 <https://reviews.llvm.org/D37184> patch

My only question is whether we should have leading zeros to guarantee a specific width for a given type?

================
Comment at: llvm/test/CodeGen/X86/pr40730.ll:23
+; CHECK-NEXT: .quad   0x1000000000
+; CHECK-NEXT: .quad   0xe0000000d

----------------
Should all these be the full .quad width (i.e. leading zeros)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73566/new/

https://reviews.llvm.org/D73566