[PATCH] D70468: [ELF] Error if -Ttext-segment is specified

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D70468#1857300 <https://reviews.llvm.org/D70468#1857300>, @troyj wrote:

> > Unfortunately currently this is supported by GNU ld's COFF port but not by its ELF port. gold does not support this option.
>
> Just picked up this commit downstream today and likely will be reverting it locally.  I think it was a bad decision to remove an option like this when the expected replacement isn't supported by the other linkers yet.  Some of us have environments where not everything is aware of the different nuances between bfd/gold/lld and so scripts supply common options to all three, which generally tends to work for most common options.  As such, switching to --image-base isn't an option until the other linkers also support it.


@troyj I think it was a good decision. As the description says, -Ttext and -Ttext-segment are different. gold incorrectly treats them the same. lld incorrectly did that too, with a different interpretation. D70468 <https://reviews.llvm.org/D70468> made it clear that -Ttext-segment is not supported. If you are happy with the previous behavior, s/-Ttext-segment/-Ttext/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70468/new/

https://reviews.llvm.org/D70468