[PATCH] D73973: Revert "[TSan] #include header instead of forward declaring interceptees"

[dmajor via Phabricator via llvm-commits]

dmajor added a comment.

Incidentally I wrote up this same patch and applied it locally earlier today, and our build still fails with the error below. Any ideas?

  [task 2020-02-04T17:06:45.025Z] Undefined symbols for architecture x86_64:
  [task 2020-02-04T17:06:45.025Z]   "_os_unfair_lock_trylock", referenced from:
  [task 2020-02-04T17:06:45.025Z]       _wrap_os_unfair_lock_trylock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]       __tsan::substitution_os_unfair_lock_trylock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]      (maybe you meant: _wrap_os_unfair_lock_trylock)
  [task 2020-02-04T17:06:45.025Z]   "_os_unfair_lock_unlock", referenced from:
  [task 2020-02-04T17:06:45.025Z]       _wrap_os_unfair_lock_unlock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]       __tsan::substitution_os_unfair_lock_unlock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]      (maybe you meant: _wrap_os_unfair_lock_unlock)
  [task 2020-02-04T17:06:45.025Z]   "_os_unfair_lock_lock", referenced from:
  [task 2020-02-04T17:06:45.025Z]       _wrap_os_unfair_lock_lock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]       __tsan::substitution_os_unfair_lock_lock in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]      (maybe you meant: _wrap_os_unfair_lock_lock, _wrap_os_unfair_lock_lock_with_options )
  [task 2020-02-04T17:06:45.025Z]   "_os_unfair_lock_lock_with_options", referenced from:
  [task 2020-02-04T17:06:45.025Z]       _wrap_os_unfair_lock_lock_with_options in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]       __tsan::substitution_os_unfair_lock_lock_with_options in tsan_interceptors_mac.cpp.o
  [task 2020-02-04T17:06:45.025Z]      (maybe you meant: _wrap_os_unfair_lock_lock_with_options)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73973/new/

https://reviews.llvm.org/D73973