[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 07:27:47 PST 2020


Meinersbur added a comment.

In my experience, LLVM tends more towards removing virtual inheritance and towards compile-time polymorphism (e.g. the pass manager, llvm::Instruction without vtable). This is a patch into the other direction. Personally, I prefer to use the language-provided mechanism.

There might be a performance impact (less inlining), it would help if you could measure it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73835/new/

https://reviews.llvm.org/D73835





More information about the llvm-commits mailing list