[PATCH] D73964: [NFC] Introduce an API for MemOp

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 06:41:48 PST 2020


courbet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:157
   uint64_t size() const { return Size; }
   uint64_t getDstAlign() const {
+    assert(!DstAlignCanChange);
----------------
LGTM with the understanding that this will go away and be replaced with `Align` eventually.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:180
+  }
+  bool isSrcAligned(unsigned AlignCheck) const {
+    return isMemset() || getSrcAlign() >= AlignCheck;
----------------
I think you can make `AlignCheck` an `Align` (here and below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73964/new/

https://reviews.llvm.org/D73964





More information about the llvm-commits mailing list