[PATCH] D73828: [yaml2obj][test] Simplify some EI_CLASS EI_DATA tests

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/relr-section.yaml:12
 # RUN: obj2yaml %t.64be | FileCheck %s --check-prefix=ELF64BE
-# RUN: yaml2obj --docnum=4 %s -o %t.32be
+# RUN: yaml2obj --docnum=1 -D BITS=32 -D ENCODE=MSB %s -o %t.64be
 # RUN: obj2yaml %t.32be | FileCheck %s --check-prefix=ELF32BE
----------------
Copy-paste error? `%t.32be`


================
Comment at: llvm/test/tools/yaml2obj/ELF/class-endianness.yaml:3-6
+# RUN: yaml2obj -D BITS=32 -D ENCODE=LSB %s | llvm-readobj --file-headers - | FileCheck %s --check-prefix LE32
+# RUN: yaml2obj -D BITS=32 -D ENCODE=MSB %s | llvm-readobj --file-headers - | FileCheck %s --check-prefix BE32
+# RUN: yaml2obj -D BITS=64 -D ENCODE=LSB %s | llvm-readobj --file-headers - | FileCheck %s --check-prefix LE64
+# RUN: yaml2obj -D BITS=64 -D ENCODE=MSB %s | llvm-readobj --file-headers - | FileCheck %s --check-prefix BE64
----------------
It might be worth breaking these lines up into 2 each.

Also, it's not a big deal, but to reduce differences it might be worth keeping the LE64/BE64/LE32/BE32 ordering as it was before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73828/new/

https://reviews.llvm.org/D73828