[PATCH] D73945: [NFC] Encapsulate MemOp logic

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 01:17:38 PST 2020


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:115
+  bool DstAlignCanChange;
+  Align DstAlign; // Specified alignment of the memory operation or zero if
+                  // destination alignment can satisfy any constraint.
----------------
This can no longer be zero, please update the comment.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:124
                      // constant so it does not need to be loaded.
-  uint64_t SrcAlign; // Inferred alignment of the source or zero if the memory
+  Align SrcAlign;    // Inferred alignment of the source or zero if the memory
                      // operation does not need to load the value.
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73945/new/

https://reviews.llvm.org/D73945





More information about the llvm-commits mailing list