[PATCH] D73764: [mlir] Added RankedIntElementsAttr class

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 00:59:36 PST 2020


ftynse accepted this revision.
ftynse added a comment.

LGTM after one nit is fixed.



================
Comment at: mlir/include/mlir/IR/OpBase.td:1050
+    "}, $_builder.getIntegerType(" # width # ")), "
+    "llvm::makeArrayRef($0))";
+}
----------------
Drop llvm::, ArrayRef is re-exported into the mlir namespace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73764/new/

https://reviews.llvm.org/D73764





More information about the llvm-commits mailing list