[PATCH] D73655: [MLIR] Break cyclic dependency between MLIRPass and MLIRAnalysis

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 20:30:29 PST 2020


rriddle added a comment.

In D73655#1856239 <https://reviews.llvm.org/D73655#1856239>, @stephenneuendorffer wrote:

> In D73655#1848713 <https://reviews.llvm.org/D73655#1848713>, @rriddle wrote:
>
> > I think we can break the dependency by removing all of the "test" passes that are currently in the Analysis lib. They predate the Test dialect, and should really be moved out.
>
>
> OpStats.cpp and MemRefBoundCheck.cpp also depend on the MLIRPassLibrary.  What do you want to do with these?


OpStats.cpp can be moved to Transforms for now, and MemRefBoundCheck is just a test pass so it can go into the test/lib/Transforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73655/new/

https://reviews.llvm.org/D73655





More information about the llvm-commits mailing list