[PATCH] D73886: [DebugInfo] Refine the condition to detect CIEs.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:386
+                            (IsDWARF64 && Id == DW64_CIE_ID))) ||
+                 (IsEH && !Id);
 
----------------
aprantl wrote:
> Is there any way to break this up into subexpressions and helper variables that would make this condition more easy to follow?
What about this?
```
bool IsCIE = (!IsEH && !IsDWARF64 && Id == DW_CIE_ID) ||
             (!IsEH && IsDWARF64 && Id == DW64_CIE_ID) ||
             (IsEH && !Id);
```

Or we may define a helper method, `CIE::getCIEId()`, like in D73887.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73886/new/

https://reviews.llvm.org/D73886