[PATCH] D73853: [llvm-reduce] add ReduceAttribute delta pass

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me.



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp:52
+        F.getAttributes().getFnAttributes().getNumAttributes();
+  // TODO: global variables may also have attributes.
+  return TotalAttributeCount;
----------------
Maybe include a matching TODO in extractAttributes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73853/new/

https://reviews.llvm.org/D73853