[PATCH] D70927: Introduce a CallGraph updater helper class

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D70927#1855168 <https://reviews.llvm.org/D70927#1855168>, @modocache wrote:

> Sorry if it's presumptuous of me to request changes,


That is always OK.

> but I guess @hfinkel may agree with me here that `registerOutlinedFunction` ought to be moved to `LazyCallGraph` or one of its inner classes.

I'm confused. I mentioned in my last response that you moved the "problematic" logic into `LazyCallGraph` in your patch (D72226 <https://reviews.llvm.org/D72226>), or did you do something different?
Please clarify what you want me to do that is different, or the same, to your patch. I'm happy to move logic into the `LazyCallGraph` class for example.

I mean in your patch `registerOutlinedFunction` looks "clean":

  void CallGraphUpdater::registerOutlinedFunction(Function &NewFn) {
    if (CG) {
      CG->addToCallGraph(&NewFn);
    } else if (LCG) {
      LazyCallGraph::Node &CGNode = createNode(*LCG, NewFn);
      addNodeToSCC(*LCG, *SCC, CGNode);
    }
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70927/new/

https://reviews.llvm.org/D70927