[PATCH] D73915: AMDGPU: Add flag to control mem intrinsic expansion

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 13:24:10 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp:68
   ConstantInt *CI = dyn_cast<ConstantInt>(Size);
-  return !CI || (CI->getZExtValue() > MaxStaticSize);
+  return !CI || (CI->getSExtValue() > MaxStaticSize);
 }
----------------
arsenm wrote:
> rampitec wrote:
> > Why signed?
> To handle using negative values with the flag
But why do you even need it negative?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73915/new/

https://reviews.llvm.org/D73915





More information about the llvm-commits mailing list