[PATCH] D73817: Add PassManagerImpl.h to hide implementation details

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

It looks like this may have broken the modules build? Could you take a look?

(To reproduce, pass `-DLLVM_ENABLE_MODULES=1` to cmake.)

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/7775/

  project/llvm/include/llvm/IR/PassManagerImpl.h:18:
  In file included from <module-includes>:1:
  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/Argument.h:19:10: fatal error: cyclic dependency in module 'LLVM_IR': LLVM_IR -> LLVM_intrinsic_gen -> LLVM_IR
  #include "llvm/IR/Value.h"
           ^
  While building module 'LLVM_IR' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/DIBuilder.cpp:13:
  In file included from <module-includes>:36:
  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/PassManagerImpl.h:18:10: fatal error: could not build module 'LLVM_intrinsic_gen'
  #include "llvm/IR/PassManager.h"
   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/DIBuilder.cpp:13:10: fatal error: could not build module 'LLVM_IR'
  #include "llvm/IR/DIBuilder.h"
   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
  3 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73817/new/

https://reviews.llvm.org/D73817