[PATCH] D72533: [mlir] Add a signedness semantics bit to IntegerType

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 11:39:02 PST 2020


dcaballe added inline comments.
Herald added a subscriber: Joonsoo.


================
Comment at: mlir/include/mlir/IR/StandardTypes.h:101
+  /// Get or create a new IntegerType of the given width within the context.
+  /// The created IntegerType has sigedness semantics as indicated via
+  /// `signedness`. Assume the width is within the allowed range and assert on
----------------
sigedness  -> signedness


================
Comment at: mlir/include/mlir/IR/StandardTypes.h:115
+  /// defined at the given, potentially unknown, location. The created
+  /// IntegerType has sigedness semantics as indicatd via `signedness`. If the
+  /// width is outside the allowed range, emit errors and return a null type.
----------------
sigedness -> signedness
indicatd -> indicated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72533/new/

https://reviews.llvm.org/D72533





More information about the llvm-commits mailing list