[PATCH] D73851: [ThinLTO] More efficient export computation (NFC)

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 3 inline comments as done.
tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:680
+      // there as to why.
+      auto *S = Index.findSummaryInModule(EI, ELI.first());
+      assert(S);
----------------
evgeny777 wrote:
> On the average this will iterate over N/2 summaries in EI.getSummaryList(). Can this be replaced with:
> ```
> auto *S = DefinedGVSummaries[EI.getGUID()];
> ```
> ? Probably the assetion above can be removed after that.
Great idea! I measured this change and there might have been a small <1s speedup, although that's within the noise range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73851/new/

https://reviews.llvm.org/D73851