[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 08:30:41 PST 2020


SouraVX updated this revision to Diff 242083.
SouraVX added a comment.

This revision, rebase itself on top of @dblaikie https://reviews.llvm.org/rG9e8bff71d073abf0ef7f8bb4ac04ec8689babcad
Thanks @dblaikie for this, that was in my mind, but initially I thought, I should seek your comments/suggestion on the overall patch first. 
Certainly it's still has some issues, since it is also built/uses existing `macinfo` infra. Primary reason behind going towards this approach was that macinfo and new macro section, Shares couple of common things -> encodings, internal storage and dumping infra can be shared.
But, I'm open to suggestions, If you think `macro` dumping infra should be separate from `macinfo`  from ground up we can do that also.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-v5.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.242083.patch
Type: text/x-patch
Size: 17791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200203/b5fdf008/attachment.bin>


More information about the llvm-commits mailing list