[llvm] 028579b - [X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 07:39:32 PST 2020


Author: Craig Topper
Date: 2020-02-03T07:39:00-08:00
New Revision: 028579b51e578f699eb9da44fb2becfea2439879

URL: https://github.com/llvm/llvm-project/commit/028579b51e578f699eb9da44fb2becfea2439879
DIFF: https://github.com/llvm/llvm-project/commit/028579b51e578f699eb9da44fb2becfea2439879.diff

LOG: [X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW.

These instructions can set the exception in FPSW. But I
don't think they can change FPCW. So this looks like a typo.

Differential Revision: https://reviews.llvm.org/D73864

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86InstrFPStack.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86InstrFPStack.td b/llvm/lib/Target/X86/X86InstrFPStack.td
index d2e790c37f8c..ab9112fde8f3 100644
--- a/llvm/lib/Target/X86/X86InstrFPStack.td
+++ b/llvm/lib/Target/X86/X86InstrFPStack.td
@@ -645,7 +645,7 @@ def COM_Fpr80  : FpI_  <(outs), (ins RFP80:$lhs, RFP80:$rhs), CompareFP,
 
 let SchedRW = [WriteFCom], mayRaiseFPException = 1 in {
 // CC = ST(0) cmp ST(i)
-let Defs = [EFLAGS, FPCW], Uses = [FPCW] in {
+let Defs = [EFLAGS, FPSW], Uses = [FPCW] in {
 def UCOM_FpIr32: FpI_<(outs), (ins RFP32:$lhs, RFP32:$rhs), CompareFP,
                   [(set EFLAGS, (X86any_fcmp RFP32:$lhs, RFP32:$rhs))]>,
                   Requires<[FPStackf32, HasCMov]>;


        


More information about the llvm-commits mailing list