[PATCH] D73760: [X86] -fpatchable-function-entry=N,0: place patch label after ENDBR{32,64}

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 06:50:31 PST 2020


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Thanks for the patch. This looks more consistent with aarch64 now. + some x86 folks in cases there's more to `endbr{32|64}` than meets the eye.



================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry-ibt.ll:68
+; CHECK-LABEL: f1i:
+; CHECK-NEXT: .Lfunc_begin3:
+; CHECK:      # %bb.0:
----------------
Do you want to add a `CHECK-NEXT` that the `.cfi_startproc` is placed after this `CHECK`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73760/new/

https://reviews.llvm.org/D73760





More information about the llvm-commits mailing list