[PATCH] D70970: [llvm-objcopy][WebAssembly] Add dump/add/remove-section support
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 01:50:18 PST 2020
jhenderson added a comment.
Looks good. Perhaps worth a test case for --dump-section + --remove-section for the same section? That feels like an important interaction to me.
================
Comment at: llvm/test/tools/llvm-objcopy/wasm/add-section.test:20-21
+# REPLACE: - Type: CUSTOM
+# REPLACE: Name: foo
+# REPLACE: Payload: 3132330A
+
----------------
Nit: delete a space on these two lines so that Type/Name/Payload all line up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70970/new/
https://reviews.llvm.org/D70970
More information about the llvm-commits
mailing list