[PATCH] D72475: [WIP] Build assume from call

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 12:06:01 PST 2020


jdoerfert added a comment.

In D72475#1853751 <https://reviews.llvm.org/D72475#1853751>, @fhahn wrote:

> Is this approach documented somewhere in-tree? I think it would be good to document it, rather than just having a link to the mailing list.


Lang Ref needs to be updated now. Agreed. @Tyker do you want to do that or should I?



================
Comment at: llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h:9
+//
+// This file contain tools to preserve informations. They should be used before
+// performing a transformation moving and deleting instruction as those
----------------
fhahn wrote:
> I think it would be good to describe what kinds of information are preserved.
That is always hard to keep in sync. I would prefer a generic file comment and alternatively more details on the `BuildAssumeFromInst` description below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475





More information about the llvm-commits mailing list