[PATCH] D73826: [mlir][Linalg][WIP][RFC] OpGen hooks

Sun Feb 2 11:28:56 PST 2020

jpienaar added a comment.

In D73826#1853301 <https://reviews.llvm.org/D73826#1853301>, @nicolasvasilache wrote:

> In D73826#1853293 <https://reviews.llvm.org/D73826#1853293>, @mehdi_amini wrote:
>
> > In D73826#1853198 <https://reviews.llvm.org/D73826#1853198>, @jpienaar wrote:
> >
> > > The previous rev was reverted as during discussion this feature was seen as unclear if we wanted to support, was changing the functionality & contract of the tool. Opening a new rev while rolling in the previous change does not resolve that discussion.
> >
> >
> > At least now there is a motivation / example of uses to support the discussion!
> >
> > I'm still not convinced that hooking into Tablegen C++ is something we want Dialect author to do, so I'd like to look closer into what you're trying to do here and see how we could achieve this without injecting code into TableGen emitters.
>
>
> I am not either and I am looking forward to getting better suggestions and moving the needle on this longstanding issue in Linalg.

The above functionality could already be handled with OpInterfaces + the way export generation is handled for TFLite dialect [which doesn't use OpInterfaces as that predated it, but could], one need not change OpDefinitionGen to get this behavior.

Another benefit to coupling with OpInterfaces is that it also serves to pushed one to think more about the core properties being taken advantage of.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73826/new/

https://reviews.llvm.org/D73826