[PATCH] D73287: AMDGPU/GlobalISel: Combine FMIN_LEGACY/FMAX_LEGACY

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

> Most of our target combines belong post-legalize and post-regbankselect. I'm mostly just unsure how to organize the 3 combiner passes which largely overlap. I'm not sure if we should juts have one combiner pass run in 3 different modes, or actually 3 distinct passes.

Maybe go with 3 distinct passes that have some sort of common base / place where shared code can go?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCombine.td:23
+
+// Combines which should only apply on SI/VI
+def gfx6gfx7_combines : GICombineGroup<[fcmp_select_to_fmin_fmax_legacy]>;
----------------
Should have been CI rather than VI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73287/new/

https://reviews.llvm.org/D73287