[PATCH] D73784: [FPEnv][AArch64] Add lowering of f128 STRICT_FSETCC

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 07:59:07 PST 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:5293
 
   if (LHS.getValueType().isInteger()) {
     SDValue CCVal;
----------------
pengfei wrote:
> john.brawn wrote:
> > pengfei wrote:
> > > Does integer comparison have strict version?
> > No. What's happening here for f128 is that just above we have a call to softenSetCCOperands that has turned the LHS into a function call that returns an integer result.
> Oh I see, thanks!
And in that case the chain is updated to the call, so we use the new one here?

And in other integer cases we do not ever care about the chain?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73784/new/

https://reviews.llvm.org/D73784





More information about the llvm-commits mailing list